“Patches Welcome”

Categorized under:

Photo of author
Written By Brian Krogsgard

7 thoughts on ““Patches Welcome””

  1. As a lead dev for a major e-commerce plugin, I’ve definitely been guilty of this. Though it’s usually in the form of “PRs welcome”, the same argument applies.

    Interesting that you bring it up today, though – I received an email from a user today who had some great feedback on a potential bug and I did indeed point him to GitHub. It was a great experience for him to be able to engage our developer community and get more eyes on his issue than just my own. He wasn’t capable of making any changes to the actual codebase, but by bringing his feedback into a collaborative environment, it was made to be incredibly useful.

    Great post, Brian.

  2. I’ve experienced this with programs and libraries I have just started to use and don’t know the internals yet. There’s been a couple of cases where I’ve experienced a problem and opened an issue on GitHub only to be told to submit a PR. It’s very off-putting and frustrating, especially since if it’s something I understand I *will* submit a PR along with the issue.

    I’d much rather hear “Thanks for the idea. Do you have any recommendations on how to implement it?” That at least opens up conversation and allows me to honestly answer with a suggestion or admit that I have no idea.

  3. I absolutely loathe that statement. and I’ve honestly never seen it used with a real sense of collaboration, rather, its been a way to tell someone to shut up and leave (person) alone. Feedback is great, and needed, but simply telling someone “patches welcome” is dismissing them.

  4. Thanks for this post and for the interpretation of the phrase. I’ve been on the receiving end of a “patches welcome” and followed up by submitting the “welcomed” patch. But so far it’s sat out there without any acknowledgement. Now I know. 🙂

Comments are closed.

A2 Hosting